Correct LMS names and add mechanics institutes phone numbers #33

Merged
lissertations merged 4 commits from master into master 2021-01-26 07:37:18 +11:00
lissertations commented 2021-01-25 21:13:29 +11:00 (Migrated from github.com)

Fixes #30 + #31 + #32. Note that some mechanics institutes do not have phone numbers, which suggests they may no longer be fully operational

Fixes #30 + #31 + #32. Note that some mechanics institutes do not have phone numbers, which suggests they may no longer be fully operational
hughrun commented 2021-01-25 22:02:57 +11:00 (Migrated from github.com)

Thanks for this PR!

I'll believe you on WorldCat/WorldShare, clearly "WorldCat" is not a real ILS anyway.

In order to make this work properly the names in the getIlsColor function in website/load-map.js need to be updated to match the changes you made in the data file. Are you able to make that change also and amend this PR accordingly? AIUI if you simply push another commit to your branch (in this case master) it should be added to this PR. I think. Let's find out!

Unfortunately I haven't yet got the auto-update-the-topojson thing working yet so I'll then need to do that manually anyway, so let me know if you'd rather I just update the JS myself.

Thanks for this PR! I'll believe you on WorldCat/WorldShare, clearly "WorldCat" is not a real ILS anyway. In order to make this work properly the names in the `getIlsColor` function in `website/load-map.js` need to be updated to match the changes you made in the data file. Are you able to make that change also and amend this PR accordingly? AIUI if you simply push another commit to your branch (in this case `master`) it should be added to this PR. I think. Let's find out! Unfortunately I haven't yet got the auto-update-the-topojson thing working yet so I'll then need to do that manually anyway, so let me know if you'd rather I just update the JS myself.
lissertations commented 2021-01-25 22:07:29 +11:00 (Migrated from github.com)

Done.

Done.
Sign in to join this conversation.
No description provided.