Correct LMS names and add mechanics institutes phone numbers #33
No reviewers
Labels
No labels
auto update
bug
data
documentation
duplicate
enhancement
for discussion
good first issue
help wanted
invalid
plumbing
question
web design
website content
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: hugh/public_library_map#33
Loading…
Reference in a new issue
No description provided.
Delete branch "master"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #30 + #31 + #32. Note that some mechanics institutes do not have phone numbers, which suggests they may no longer be fully operational
Thanks for this PR!
I'll believe you on WorldCat/WorldShare, clearly "WorldCat" is not a real ILS anyway.
In order to make this work properly the names in the
getIlsColor
function inwebsite/load-map.js
need to be updated to match the changes you made in the data file. Are you able to make that change also and amend this PR accordingly? AIUI if you simply push another commit to your branch (in this casemaster
) it should be added to this PR. I think. Let's find out!Unfortunately I haven't yet got the auto-update-the-topojson thing working yet so I'll then need to do that manually anyway, so let me know if you'd rather I just update the JS myself.
Done.