hugh/public_library_map
hugh/public_library_map
1
Fork 0
Code Issues 9 Pull requests Actions Packages Projects Releases Wiki Activity

Correct LMS names and add mechanics institutes phone numbers #33

Merged
lissertations merged 4 commits from master into master 2021-01-26 07:37:18 +11:00
Conversation 2 Commits 4 Files changed 4 +170 -171
lissertations commented 2021-01-25 21:13:29 +11:00 (Migrated from github.com)
Copy link

Fixes #30 + #31 + #32. Note that some mechanics institutes do not have phone numbers, which suggests they may no longer be fully operational

Fixes #30 + #31 + #32. Note that some mechanics institutes do not have phone numbers, which suggests they may no longer be fully operational
hughrun commented 2021-01-25 22:02:57 +11:00 (Migrated from github.com)
Copy link

Thanks for this PR!

I'll believe you on WorldCat/WorldShare, clearly "WorldCat" is not a real ILS anyway.

In order to make this work properly the names in the getIlsColor function in website/load-map.js need to be updated to match the changes you made in the data file. Are you able to make that change also and amend this PR accordingly? AIUI if you simply push another commit to your branch (in this case master) it should be added to this PR. I think. Let's find out!

Unfortunately I haven't yet got the auto-update-the-topojson thing working yet so I'll then need to do that manually anyway, so let me know if you'd rather I just update the JS myself.

Thanks for this PR! I'll believe you on WorldCat/WorldShare, clearly "WorldCat" is not a real ILS anyway. In order to make this work properly the names in the `getIlsColor` function in `website/load-map.js` need to be updated to match the changes you made in the data file. Are you able to make that change also and amend this PR accordingly? AIUI if you simply push another commit to your branch (in this case `master`) it should be added to this PR. I think. Let's find out! Unfortunately I haven't yet got the auto-update-the-topojson thing working yet so I'll then need to do that manually anyway, so let me know if you'd rather I just update the JS myself.
lissertations commented 2021-01-25 22:07:29 +11:00 (Migrated from github.com)
Copy link

Done.

Done.
🎉 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
auto update

This PR or issue has been amended or created by a bot

  
bug

Something isn't working

  
data

related to mapping data

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
for discussion

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
plumbing

To do with GitHub or data workflows

  
question

Further information is requested

  
web design

to do with styling formatting etc of the website

  
website content

related to information on the website (i.e. in sentences, not mapping data)

  
wontfix

This will not be worked on

No labels
auto update
bug
data
documentation
duplicate
enhancement
for discussion
good first issue
help wanted
invalid
plumbing
question
web design
website content
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: hugh/public_library_map#33
No description provided.
Delete branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?