hugh/public_library_map
hugh/public_library_map
1
Fork 0
Code Issues 9 Pull requests Actions Packages Projects Releases Wiki Activity

normalise service names #35

Merged
hughrun merged 1 commit from prep-new-workflow into master 2021-01-26 14:45:33 +11:00
Conversation 0 Commits 1 Files changed 4 +462 -472
hughrun commented 2021-01-26 14:43:50 +11:00 (Migrated from github.com)
Copy link
  • titlecase all library service short names in csv file
  • rename short_name to name in csv
  • replace merge_service_data.py with merge_to_topo.py in preparation to deal with #18 and #34

Fixes #25

NEW WORKFLOW if changing boundary shapes

  • update boundaries.geojson if needed
  • geo2topo -q 12000
  • THEN run merge_to_topo.py (i.e. we merge the topoJSON not the geoJSON)

NEW WORKFLOW if changing service data

  • merge pull request containing changes to library_services_information.csv
  • run Action which runs merge_to_topo and then updates main HEAD topofile
- titlecase all library service short names in csv file - rename `short_name` to `name` in csv - replace merge_service_data.py with merge_to_topo.py in preparation to deal with #18 and #34 Fixes #25 NEW WORKFLOW if changing boundary shapes - update boundaries.geojson if needed - geo2topo -q 12000 - THEN run merge_to_topo.py (i.e. we merge the topoJSON not the geoJSON) NEW WORKFLOW if changing service data - merge pull request containing changes to library_services_information.csv - run Action which runs merge_to_topo and then updates main HEAD topofile
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
auto update

This PR or issue has been amended or created by a bot

  
bug

Something isn't working

  
data

related to mapping data

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
for discussion

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
plumbing

To do with GitHub or data workflows

  
question

Further information is requested

  
web design

to do with styling formatting etc of the website

  
website content

related to information on the website (i.e. in sentences, not mapping data)

  
wontfix

This will not be worked on

No labels
auto update
bug
data
documentation
duplicate
enhancement
for discussion
good first issue
help wanted
invalid
plumbing
question
web design
website content
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: hugh/public_library_map#35
No description provided.
Delete branch "prep-new-workflow"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?